[rhosdt] Fix stage tests branch parameter name for Gangway override - #80118
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 4, 2026
Merged
Conversation
…refix Rename OTEL_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH and TEMPO_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCH in both ref YAMLs and command scripts. The MULTISTAGE_PARAM_OVERRIDE_ prefix is required for ci-operator to recognise the variable as an overridable parameter and inject values passed via Gangway API pod_spec_options into the step container. Without this prefix the pod-level env var is ignored by ci-operator and the step receives an empty string, causing the runtime guard to fire. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
WalkthroughThis PR renames environment variables in distributed-tracing test stage configurations to follow a ChangesDistributed-Tracing Test Stage Parameter Naming
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
Author
|
/pj-rehearse ack |
Contributor
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
openshift-ci
Bot
added
the
approved
Contributor
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
|
@IshwarKanse: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: etmurasaki, IshwarKanse The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TimurMP
pushed a commit
to TimurMP/release
that referenced
this pull request
Jun 4, 2026
…refix (openshift#80118) Rename OTEL_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH and TEMPO_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCH in both ref YAMLs and command scripts. The MULTISTAGE_PARAM_OVERRIDE_ prefix is required for ci-operator to recognise the variable as an overridable parameter and inject values passed via Gangway API pod_spec_options into the step container. Without this prefix the pod-level env var is ignored by ci-operator and the step receives an empty string, causing the runtime guard to fire. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Jun 8, 2026
krisnababu
pushed a commit
to oharan2/release
that referenced
this pull request
Jul 3, 2026
…refix (openshift#80118) Rename OTEL_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH and TEMPO_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCH in both ref YAMLs and command scripts. The MULTISTAGE_PARAM_OVERRIDE_ prefix is required for ci-operator to recognise the variable as an overridable parameter and inject values passed via Gangway API pod_spec_options into the step container. Without this prefix the pod-level env var is ignored by ci-operator and the step receives an empty string, causing the runtime guard to fire. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
andrej1991
pushed a commit
to andrej1991/release
that referenced
this pull request
Jul 6, 2026
…refix (openshift#80118) Rename OTEL_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH and TEMPO_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCH in both ref YAMLs and command scripts. The MULTISTAGE_PARAM_OVERRIDE_ prefix is required for ci-operator to recognise the variable as an overridable parameter and inject values passed via Gangway API pod_spec_options into the step container. Without this prefix the pod-level env var is ignored by ci-operator and the step receives an empty string, causing the runtime guard to fire. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
TimurMP
pushed a commit
to TimurMP/release
that referenced
this pull request
Jul 8, 2026
…refix (openshift#80118) Rename OTEL_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH and TEMPO_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCH in both ref YAMLs and command scripts. The MULTISTAGE_PARAM_OVERRIDE_ prefix is required for ci-operator to recognise the variable as an overridable parameter and inject values passed via Gangway API pod_spec_options into the step container. Without this prefix the pod-level env var is ignored by ci-operator and the step receives an empty string, causing the runtime guard to fire. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
SachinNinganure
pushed a commit
to SachinNinganure/release
that referenced
this pull request
Jul 20, 2026
…refix (openshift#80118) Rename OTEL_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH and TEMPO_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCH in both ref YAMLs and command scripts. The MULTISTAGE_PARAM_OVERRIDE_ prefix is required for ci-operator to recognise the variable as an overridable parameter and inject values passed via Gangway API pod_spec_options into the step container. Without this prefix the pod-level env var is ignored by ci-operator and the step receives an empty string, causing the runtime guard to fire. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
malingatembo
pushed a commit
to malingatembo/release
that referenced
this pull request
Aug 5, 2026
…refix (openshift#80118) Rename OTEL_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH and TEMPO_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCH in both ref YAMLs and command scripts. The MULTISTAGE_PARAM_OVERRIDE_ prefix is required for ci-operator to recognise the variable as an overridable parameter and inject values passed via Gangway API pod_spec_options into the step container. Without this prefix the pod-level env var is ignored by ci-operator and the step receives an empty string, causing the runtime guard to fire. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
TimurMP
pushed a commit
to TimurMP/release
that referenced
this pull request
Sep 5, 2026
…refix (openshift#80118) Rename OTEL_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH and TEMPO_TESTS_BRANCH to MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCH in both ref YAMLs and command scripts. The MULTISTAGE_PARAM_OVERRIDE_ prefix is required for ci-operator to recognise the variable as an overridable parameter and inject values passed via Gangway API pod_spec_options into the step container. Without this prefix the pod-level env var is ignored by ci-operator and the step receives an empty string, causing the runtime guard to fire. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename
OTEL_TESTS_BRANCH→MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCHandTEMPO_TESTS_BRANCH→MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCHin the otel and tempo stage test ref YAMLs and command scripts.The
MULTISTAGE_PARAM_OVERRIDE_prefix is required for ci-operator to recognise a variable as an overridable parameter and inject values supplied via Gangway APIpod_spec_options.envsinto the step container. Without the prefix, ci-operator ignores the pod-level env var and the step receives an empty string, causing the runtime guard to fail withis not set.Test plan
MULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCH/MULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCHset clone the correct branch and run tests successfully🤖 Generated with Claude Code
Summary by CodeRabbit
This PR fixes the stage test configuration for distributed tracing (OpenTelemetry and Tempo) by renaming environment variables to use the
MULTISTAGE_PARAM_OVERRIDE_prefix that ci-operator requires to recognize them as overridable parameters.What changed:
OTEL_TESTS_BRANCHtoMULTISTAGE_PARAM_OVERRIDE_OTEL_TESTS_BRANCHin OpenTelemetry stage test configuration and scriptTEMPO_TESTS_BRANCHtoMULTISTAGE_PARAM_OVERRIDE_TEMPO_TESTS_BRANCHin Tempo stage test configuration and scriptWhy it matters:
Without the
MULTISTAGE_PARAM_OVERRIDE_prefix, ci-operator ignores pod-level environment variables and the test steps receive empty strings instead. The prefix is necessary for Gangway API to properly inject branch override values frompod_spec_options.envsinto the step containers. This fix enables the distributed tracing stage jobs to accept custom branch parameters when triggered via Gangway, allowing teams to test against different branches before merging.Impact:
Distributed tracing stage jobs will now correctly receive branch override values from Gangway, and will immediately fail with a clear error message if the required branch variables are not provided, rather than proceeding with empty values.